-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delivery of the 2nd milestone (TPScore) #1013
Conversation
Thanks for the delivery @its-a-setup and sorry for the delay. You can find my evaluation here.I just have two questions about the stats.
|
Hi @keeganquigley Below are the answers:
|
Thanks @its-a-setup for the explanation and for updating the feeds. I'm still curious about how benchmarking was performed for these results. I know TPS metrics are subjective, but as this wiki article notes, Polkadot and substrate-based chains should be able to achieve somewhere over 1000 tx/s for simple balance transfers. I know that some parachains might not have much activity, but the Polkadot relay chain itself has a lot of activity. So I would think at least this metric would be higher. Are these benchmarks accounting for the different block times of each chain? What about latency? I agree it might help to include other extrinsics than just transfers, especially for chains that don't have a lot of transfers happening. Any further explanation you can give regarding the results and how you got them would be great. Thanks! |
Sure, let's dive deeper into that! As for the Relay Chain specifically, we can do a quick check and take a look at the last 20 blocks (e.g. 17598627 - 17598646) and we will see that at max blocks have 2 transactions of type "Balances" (e.g. in block 17598637). In total these 20 blocks have 6 transactions of type "Balances", considering that the time between blocks is 114 seconds, it will mean that TPS is 0.05, which is perfectly in line with calculations based on 100 blocks.
Irrespective of block time, we still take 100 blocks for any chain
We don't consider it at the moment |
Thanks for the clarifications @its-a-setup much appreciated. I still recommend perhaps displaying more decimal places or something like that, but I'm happy to go ahead pass the milestone. Nice work! Please allow for up to 14 days for processing. |
This comment has been minimized.
This comment has been minimized.
We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊 |
@keeganquigley thank you! As for the 0 TPS values for some of the chains, it will be one of our core focuses moving forward. It's also super important to make TPS calculation consistent between parachains and blockchain networks outside of the Polkadot ecosystem so that dApp builders could get a better insight on which parachain they should build. We will try to make an improvement on that in the 2nd version of our app. |
Milestone Delivery Checklist
Link to the application pull request: 1837